Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Fix tests that depend on specific config values to use the "scoped" feature #229

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

ZoteTheMighty
Copy link
Contributor

Fixes a test that may fail if not run with the bin/spec.lua test runner. The tests depend on having the typeChecks global config value set to true, but did not express this dependency as written.

Checklist before submitting:

  • Added entry to CHANGELOG.md
  • Added/updated relevant tests
  • Added/updated documentation

@ZoteTheMighty ZoteTheMighty changed the title Fixes test that depends on specific config values to use the feature Fixes test that depends on specific config values to use the "scoped" feature Aug 9, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.28% when pulling fa44700 on ZoteTheMighty:fix-binding-test into 9493406 on Roblox:master.

@ZoteTheMighty ZoteTheMighty changed the title Fixes test that depends on specific config values to use the "scoped" feature Fix tests that depend on specific config values to use the "scoped" feature Aug 9, 2019
@ZoteTheMighty ZoteTheMighty requested review from AmaranthineCodices and LPGhatguy and removed request for AmaranthineCodices August 9, 2019 18:44
@MisterUncloaked MisterUncloaked self-requested a review August 9, 2019 20:11
@LPGhatguy LPGhatguy merged commit dad8c75 into Roblox:master Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants