Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Fix usage of error() in createReconciler.lua #297

Merged
merged 3 commits into from May 7, 2021
Merged

Fix usage of error() in createReconciler.lua #297

merged 3 commits into from May 7, 2021

Conversation

LoganDark
Copy link
Contributor

Luau started working for me and it caught this so I decided I'd open a quick PR to fix it.

@LoganDark
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link

github-actions bot commented Mar 8, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@LoganDark
Copy link
Contributor Author

LoganDark commented Mar 18, 2021

@LPGhatguy please review

@Kampfkarren
Copy link
Contributor

LPG isn't involved with the Roblox repos anymore.

@LoganDark
Copy link
Contributor Author

LPG isn't involved with the Roblox repos anymore.

:( I don't know who to poke... is it normal for a 3 line change to take this long?

@Kampfkarren
Copy link
Contributor

From the looks of it, I don't think PRs get merged on Roact anymore.

Copy link
Contributor

@oltrep oltrep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this 👍

@ZoteTheMighty that looks good to me, it will change the stack traces a little but that should not cause any problem I think

@ZoteTheMighty
Copy link
Contributor

Hi @LoganDark , thanks for your contribution! Could you update this branch? It should pull in the ci.yml changes that seem to fix coverage reporting, and then we can get that ✔️ from CI!

@LoganDark
Copy link
Contributor Author

Hi @LoganDark , thanks for your contribution! Could you update this branch? It should pull in the ci.yml changes that seem to fix coverage reporting, and then we can get that ✔️ from CI!

Sorry for the slow response, I was asleep.

@coveralls
Copy link

coveralls commented May 7, 2021

Coverage Status

Coverage remained the same at 94.188% when pulling 6106a83 on LoganDark:patch-1 into 15ca096 on Roblox:master.

@oltrep
Copy link
Contributor

oltrep commented May 7, 2021

Oh, one last thing! Could you add an entry to the changelog, something like that would do the job:

* Fixed stack trace level when throwing an error in `createReconciler` ([#297](https://github.com/Roblox/roact/pull/290)).

@ZoteTheMighty ZoteTheMighty merged commit b685faf into Roblox:master May 7, 2021
@LoganDark LoganDark deleted the patch-1 branch May 7, 2021 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants