Fix usage of error() in createReconciler.lua #297
Conversation
I have read the CLA Document and I hereby sign the CLA |
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@LPGhatguy please review |
LPG isn't involved with the Roblox repos anymore. |
:( I don't know who to poke... is it normal for a 3 line change to take this long? |
From the looks of it, I don't think PRs get merged on Roact anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this 👍
@ZoteTheMighty that looks good to me, it will change the stack traces a little but that should not cause any problem I think
Hi @LoganDark , thanks for your contribution! Could you update this branch? It should pull in the ci.yml changes that seem to fix coverage reporting, and then we can get that ✔️ from CI! |
Sorry for the slow response, I was asleep. |
Oh, one last thing! Could you add an entry to the changelog, something like that would do the job:
|
Luau started working for me and it caught this so I decided I'd open a quick PR to fix it.