Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #55 Make logger pretty printing optional #95

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Closes #55 Make logger pretty printing optional #95

wants to merge 2 commits into from

Conversation

Pluviolithic
Copy link

  • Added prettyPrintTables option to loggerMiddleware
  • Added tests
  • Documented option

ZoteTheMighty
ZoteTheMighty approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@ZoteTheMighty ZoteTheMighty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very reasonable to me! Please run StyLua, which can be installed through foreman, and sign the CLA and we can merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZoteTheMighty ZoteTheMighty ZoteTheMighty approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pluviolithic @ZoteTheMighty