Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry to 0.18 and make it optional via a feature #32

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

arthurprs
Copy link
Contributor

@arthurprs arthurprs commented Dec 13, 2022

What problem are we solving?

  • openteletry support is using a very old version
  • openteletry might be unnecessary to most users, and there's precedent (prometheus metrics) for making such things optional with features.

How are we solving the problem?

Update opentelemetry to 0.18 and make it optional via a feature

Checks

Please check these off before promoting the pull request to non-draft status.

  • All CI checks are green.
  • I have reviewed the proposed changes myself.

@kushudai
Copy link
Contributor

Hi @arthurprs,
Thank you for this change. Could you sign the CLA so I can accept it?

@github-actions
Copy link

github-actions bot commented Jun 18, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@arthurprs
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@kushudai
Copy link
Contributor

Thank you! I will merge this and release a new version with all the breaking changes this week.

@kushudai kushudai merged commit 7637977 into Roblox:main Jun 18, 2023
@kushudai kushudai mentioned this pull request Nov 4, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants