Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry behavior to work around rate limiting #43

Closed
ZoteTheMighty opened this issue Jul 17, 2020 · 0 comments · Fixed by #45
Closed

Add retry behavior to work around rate limiting #43

ZoteTheMighty opened this issue Jul 17, 2020 · 0 comments · Fixed by #45
Labels
enhancement New feature or request

Comments

@ZoteTheMighty
Copy link
Contributor

The Roblox upload endpoint will rate-limit, which can cause problems when running Tarmac on large sets of assets. This can be especially troublesome when integrating with CI.

The upload API returns a 429 error when rate limiting occurs, and the budget is per-minute. We should be able to provide Tarmac an optional retry count, so that when it receives a 429 it will wait for one minute, then retry with the last file it was attempting to upload.
@ZoteTheMighty ZoteTheMighty added the enhancement New feature or request label Jul 17, 2020
@oltrep oltrep mentioned this issue Jul 20, 2020
Merged
ZoteTheMighty added a commit that referenced this issue Jul 23, 2020
@ZoteTheMighty
Merge pull request #45 from oltrep/retry-backend
858ba46 
Closes #43

This PR adds a new backend that wraps another one and performs the retry logic when getting rate limited errors.

I've opened this as a draft PR because I have not tested it yet with real image uploads.
@oltrep oltrep mentioned this issue Jul 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add retry backend and new command line options oltrep/tarmac
1 participant
@ZoteTheMighty