Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make supervisor synchronous #89

Merged
merged 1 commit into from
Mar 20, 2021
Merged

Conversation

Adman
Copy link
Member

@Adman Adman commented Mar 20, 2021

  • this should fix the time to speed up when
    the simulator runs at maximum speed
  • from docs: "for the robot competitions
    generally the Supervisor controller is
    synchronous while the contestants
    controllers are asynchronous"

Signed-off-by: Adrian Matejov ado.matejov@gmail.com

@Adman Adman requested a review from mrshu March 20, 2021 10:37
@mrshu
Copy link
Contributor

mrshu commented Mar 20, 2021

@Adman Looks good to me -- thanks!

Can you please link the docs to this commit? Or even better, can we link to them in the "world file"?

@Adman Adman force-pushed the adman/synchronize-supervisor branch from 9c8401e to 27c2bb4 Compare March 20, 2021 11:34
* this should fix the time to speed up when
  the simulator runs at maximum speed
* from docs: "for the robot competitions
  generally the Supervisor controller is
  synchronous while the contestants
  controllers are asynchronous"
  https://www.cyberbotics.com/doc/reference/robot#synchronous-versus-asynchronous-controllers

Signed-off-by: Adrian Matejov <ado.matejov@gmail.com>
@Adman Adman force-pushed the adman/synchronize-supervisor branch from 27c2bb4 to 2dbabb7 Compare March 20, 2021 11:35
@Adman
Copy link
Member Author

Adman commented Mar 20, 2021

@mrshu Linked in the commit to keep the world file clean. (Adjusted also template file)

@Adman Adman merged commit dacf2f7 into master Mar 20, 2021
@Adman Adman deleted the adman/synchronize-supervisor branch March 20, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants