Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

SmoothControl.cpp poor structure #356

Closed
JasonGibson274 opened this issue Mar 10, 2019 · 1 comment
Closed

SmoothControl.cpp poor structure #356

JasonGibson274 opened this issue Mar 10, 2019 · 1 comment
Assignees
Labels
type ➤ bug Bugs to existing features that need to be fixed.

Comments

@JasonGibson274
Copy link
Contributor

SmoothControl.cpp is poorly structured as a class. It uses class members to pass around data to related methods instead of just returning a value. Specifically it uses class members as temporary storage variables.

For example getLineOfSSightAndHeading() returns void and sets the heading_ variable instead of just returning a value from the method.

class members listed below should be deleted.

  • los_
  • heading_
  • tar_orientation_
  • theta_
  • delta_
  • curPose_

Method should be restructured accordingly.

@JasonGibson274 JasonGibson274 added the type ➤ bug Bugs to existing features that need to be fixed. label Mar 10, 2019
@oswinso oswinso self-assigned this Mar 10, 2019
@Alescontrela
Copy link
Contributor

Fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type ➤ bug Bugs to existing features that need to be fixed.
Projects
None yet
Development

No branches or pull requests

3 participants