Fix hard coded receiving method into order detail message. #1260
Conversation
| @@ -207,8 +207,10 @@ const OrderDetails = ({ | |||
| amount: amountString, | |||
| method: order.payment_method, | |||
| }); | |||
| receive = t('You receive via Lightning {{amount}} Sats (Approx)', { | |||
| const receives_on_chain = order.swap_fee_rate > 0; | |||
There was a problem hiding this comment.
Is order.swap_fee_rate the best param we can use for this? This might display "onchain" for everyone while they are in the step of submitting an invoice.
Ideally we have a order.is_swap boolean that is only sent to the buyer.
There was a problem hiding this comment.
Since we don't have this param from the API now I just changed the text.
rodrigodh
force-pushed
the
fix-order-detail-receive-message
branch
from
78f1815
to
8d2ca28
Compare
Inside the order detail component we have a little text telling the user how much he'sreceiving from the transaction, this commit changes the text removing the lightning word from it because sometimes the receiving method is on-chain. Ideally we would have aorder.is_swap boolean that is only sent to the buyer to identify the method but since we don't have it yet, we are just changing the text.
There was a problem hiding this comment.
Thank you @rodrigodh ! It is not the best possible solution, but at least it is not confusing anymore (that's what matters).
Congratulations on your first contribution. Please submit an invoice for 15K Sats for a small reward from the Development fund.
Thank you! I'm not sure if my Lightning Network is set up correctly, but you can try this invoice. (don't worry if it doesn't work.) I hope I can contribute even more in the future. |
|
@Reckless-Satoshi is it merging? |
I get "No Route". Please feel free to post another one with a long expiration time so I can keep retrying. Merging this PR 🚀 |
What does this PR do?
This PR introduces a fix for the order detail box about the receiving payment message, so users can have it more clear when they are receiving through on-chain or lightning.
I found this problem on my last transaction when even though i selected on-chain it was showing lightning, but was just a visual issue.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.It's important to notice that I don't have much experience with open-source or crypto, so I'm up to fix any mistake on my part.