Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 support? #12

Open
defied opened this issue Apr 9, 2019 · 8 comments
Open

ROS2 support? #12

defied opened this issue Apr 9, 2019 · 8 comments

Comments

@defied
Copy link

defied commented Apr 9, 2019

Do you have a time estimate for when / if there will be ROS2 support?

@wolfv
Copy link
Member

wolfv commented Apr 12, 2019

Hi @defied

I haven't tried ROS2 yet, to be honest! Looking at it it shouldn't be too hard to implement support...

As a first step we could make publish more configurable by adding a non-default callback on "send" click, so that you can publish the message with your own publisher.
And subscribe, we could add an argument to pass your ROS2 node and use that for subscribing.

Interested in working on that?

@defied
Copy link
Author

defied commented Apr 17, 2019

Let me get used to the product, but my work life is ridiculous, so I'm not sure how effective I would be.

@talregev
Copy link

talregev commented Jun 23, 2019

Hello @wolfv

As a first step we could make publish more configurable by adding a non-default callback on "send" click, so that you can publish the message with your own publisher.
And subscribe, we could add an argument to pass your ROS2 node and use that for subscribing.

How I get start?
I want to implement my own publisher and my own subscriber that it will use roslibpy instead rospy.

@zmk5
Copy link

zmk5 commented Oct 24, 2019

Hi guys,

I have a branch on my fork that can currently run ros2 with Ubuntu or macOS. I have converted most of the files to what needs to be done, but I may need some help understanding the full inner workings of the project. I would suggest that if this group would like to use this it should be a separate branch because a lot of things have to change for it to work. Also, this will now be supported by python3. I made some changes to the README file to make it certain that users should install the necessary dependencies using python3 -m pip ... instead of just the default pip install.

This is the branch I developed -> https://github.com/zmk5/jupyter-ros/tree/ros2

@seanyen
Copy link

seanyen commented Mar 3, 2020

@wolfv I am also interested in ROS 2 enablement. What if we have a ros2 branch so the community can start contributing the ROS 2 port?

@zmk5
Copy link

zmk5 commented Mar 7, 2020

@seanyen I already have the ros2 branch. I'm waiting on @wolfv 's ok so I can move my project over to the RoboStack repository. I think he may be busy since I haven't heard from him in a while.

@wolfv
Copy link
Member

wolfv commented Mar 8, 2020

hey @zmk5 I know -- i need to find the time to look at your changes and re-integrate them into the core jupyter-ros. or we start with a diverging branch that starts from scratch in jupyter-ros? what's most appropriate? just invited you to the org.

@zmk5
Copy link

zmk5 commented Mar 10, 2020

No worries man! I've been busy with stuff too but I hope to get back into stuff soon. I think our best bet would be to try and have it as a diverging branch. I took some liberty with the code and change how things work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants