Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages_skip_by_deps removes a bit too many packages #4

Open
wolfv opened this issue Jul 1, 2021 · 0 comments
Open

packages_skip_by_deps removes a bit too many packages #4

wolfv opened this issue Jul 1, 2021 · 0 comments

Comments

@wolfv
Copy link
Member

wolfv commented Jul 1, 2021

I tried to use packages_skip_by_deps to remove cyclonedds from the Windows build of galactic. But that also removes some dependencies that are otherwise needed (e.g. ament_cmake) since it appears somewhere in the dependency chain.

We should count how often each package is required or have some better logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant