-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 9 Tinker Plugin Bug. adds: <whisper>= </whisper> to output. #212
Comments
Have the same issue with Laravel 8. |
Did tinker or physh have an update..? Let's see. |
So there is this theme update from Psysh. Let's see if it helps by reverting to the old layout |
Laravel Tinker-2.4.0+1.zip Also, can you tell me your physh version? |
No it does not, and psy/psych is not installed. |
How is psysh not installed? laravel/tinker depends on it, this plugin likewise. |
when manually adding psy/psych to the composer.json require-dev $ composer update
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
- Downgrading psy/psysh (v0.11.9 => v0.11.8)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
- Downgrading psy/psysh (v0.11.9 => v0.11.8): Extracting archive
Generating optimized autoload files When removing it and then: composer update
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
- Upgrading psy/psysh (v0.11.8 => v0.11.9)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
- Upgrading psy/psysh (v0.11.8 => v0.11.9): Extracting archive
Generating optimized autoload files However with it not being in composer.json even And yes I installed 1 version older manually Manually installing it, it does fix the issue. |
Manually installing 0.11.8? |
Yes, a manual install of 0.11.9 breaks it and shows again. |
Alright, so it is the theme update op psysh. Command is |
Also nevermind the console outputs of the removing and adding manually. False info, read my terminal wrong. |
Right ok so with it NOT in composer.json
|
The one with the star, 0.11.9 So, i'm fairly certain the new theme system breaks output, this is enought info for me to fix it <3 |
So fun how anytime psy/psych updates you have work to do <3 |
You need like a CI something that listens for updates on the package and then auto run tests. I don't know if such things exist but I am assuming it does. |
This isn't the first time a psysh update breaks the plugin, but it's ultimately my fault for not yet having figured out how to get the ansi-colored output and just transforming that to HTML. Currently I'm doing all kinds of hocus-pocus to get colors in the output which is, well, not ideal :) |
That looks like the most "fun" functions and fun regex expressions. |
Still thanks for making this plugin in the first place, its awesome having code hinting for Tinker! |
Actually, I might have just found ansi colors |
Aight. I build an ansi color parser. The hocuspocus of regex is gone. Huzza! Also, this is fixed together with it, in 2.5.0 :) |
So whens the release? :D |
Have to fix something - looks like I'm using a deprecated function |
Version 2.5.0 is underway, pending JetBrains verification :) |
Bug description
At the start of a fresh install of laravel 9 the plugin prepends any output with
<whisper>= </whisper>
.To Reproduce
In mysql / mariadb database shell
create database test;
In console
laravel new test
migrate:fresh
In phpstorm
open tinker plugin.
enter:
Expected behavior
Screenshots
Environment
The text was updated successfully, but these errors were encountered: