Fix canRepair() not working for ZCOUNIT units #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved the conditional from replenishUnit to canRepair, for ease of use
If both types call the same function, there's no chance for mismatches
Allows for overriding a specific building type's canRepair()
Robosturm
reviewed
Apr 27, 2024
game/building.cpp
Outdated
| @@ -1164,13 +1164,20 @@ float Building::getTerrainAnimationMoveSpeed() | |||
| } | |||
| } | |||
|
|
|||
| bool Building::canRepair(Unit* pUnit) | |||
| bool Building::canRepair(Unit* pUnit, bool always = false) | |||
There was a problem hiding this comment.
This is wrong.
The line in the header building.h should be:
Q_INVOKABLE bool canRepair(Unit* pUnit, bool always = false);
The line in the header building.cpp should be:
bool Building::canRepair(Unit* pUnit, bool always)
I know I can fix after the PR, but I would prefer it the other way around.
You're code wouldn't compile atm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canRepair()only usesbuilding.getConstructionList()so farthe actual
BUILDING.replenishUnit()uses bothbuilding.getConstructionList()andbuilding.getRepairTypes()so there's a mismatch for the units that have a matching type, but aren't in the construction list (the ZCOUNIT units)
BUILDING.replenishUnit()intoBUILDING.canRepair()building.canRepair()to use the js<BUILDING_TYPE>.canRepair()