Skip to content
This repository has been archived by the owner on Nov 4, 2021. It is now read-only.

Add dynamic reconfigure server + fetch focal length from camera info topic #10

Conversation

viktorku
Copy link
Member

@viktorku viktorku commented Oct 19, 2018

Adds a couple of parameters that can be tweaked during runtime and adds a possibility to fetch the focal length from a camera info topic.

From my description in the "internal" version we (will) use at Pick-it (Intermodalics#1):

The focal length is now fetched from the camera info topic. An f_mult_factor is also exposed through dyn.reconf. for easy adjustment of unwanted artifacts due to calibration etc.

We do need to have the max_depth_per_tile configurable by dynamic reconfigure because it is strictly an encoding coefficient responsible for including/discarding depth for various ranges. With a long range camera (~2m and above) this coefficient enables those ranges to be also encoded, otherwise the resulting depth will be lost. For more info regarding this parameter see #8 and RobotWebTools/ros3djs#207

It also replaces the hardcoded 640x480 resolution to now support other resolutions (confirmed working well!) ;)

@viktorku viktorku requested a review from jihoonl October 19, 2018 12:20
@viktorku viktorku force-pushed the dynamic-reconfigure-server-upstream branch from 51f30d1 to 0524cdf Compare October 19, 2018 12:49
@jihoonl jihoonl merged commit 09107ab into RobotWebTools:develop Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants