This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
Develop closecloud encoding #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does add a dependency to TF and PCL but makes the encoder much more flexible in what it can encode. Signed-off-by: Peter Soetens <peter@thesourceworks.com>
…se of color channels. This patch also needs a change on the Depthcloud.js side. We could encode these mapping settings on a separate topic for Depthcloud.js to pickup again. Signed-off-by: Peter Soetens <peter@thesourceworks.com>
Signed-off-by: Peter Soetens <peter@thesourceworks.com>
Signed-off-by: Peter Soetens <peter@thesourceworks.com>
…se multiple options are available Without this, we would always subscribe to the cloud topic, even if it was not set in the launch file, but it was set in the rosparam server. Signed-off-by: Peter Soetens <peter@intermodalics.eu>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two features: encoding a pointcloud instead of just depth images and improving the resolution by factor 6 by shrinking the range to 0-2m and using the RGB channels separately to encode depth.
The ros3djs pull request 107 depends on this one to render the depthclouds correctly in this new resolution.