Fix crashing on Electron > 21 #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Electron 21, the V8 sandboxed pointers was enabled, which disables creating a new BackingStore and take over an external memory block. Instead, we must copy the data into a newly-allocated memory that is inside V8 memory cage. See more details: https://www.electronjs.org/blog/v8-memory-cage This patch fixed the crashing when running on Electron > 21. Fix RobotWebTools#864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Electron 21, the V8 sandboxed pointers was enabled, which disables creating a new BackingStore and taking over an external memory block. Instead, we must copy the data into a newly-allocated memory that is inside V8 memory cage.
See more details: https://www.electronjs.org/blog/v8-memory-cage
This patch fixed the crashing when running on Electron > 21.
Testing
Electron v25.0.1 with Iron
electron --expose-gc ./scripts/run_test.jselectron example/subscription-message-example.js&node example/publisher-message-example.jsNodejs v18.16.0 with Iron
npm testFix #864