Additional client information websocket #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks. |
jihoonl
approved these changes
Mar 28, 2019
| def remove_client(self, client_id, ip_address): | ||
| with self._lock: | ||
| self._clients.pop(client_id, None) | ||
| self.__publish() |
jihoonl
approved these changes
Mar 28, 2019
|
|
||
| def add_client(self, client_id, ip_address): | ||
| with self._lock: | ||
| client = ConnectedClient() |
mvollrath
requested changes
Mar 28, 2019
|
This PR has quite some commits now. I can rebase and squash my commits if that desired. |
mvollrath
approved these changes
Mar 28, 2019
|
Note that this PR introduced a new dependency on rosbridge_server. So, we need to release with minor patch bump for the next release. |
|
I would like to prevent certain IP addresses from connecting to rosbridge websocket server. |
|
@ramezanifar system firewall features are good for that, if you are using Ubuntu look at |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latches a list of all connected clients, where each client is described by
This only works for the websocket server for now. Let me know if this is something useful. If so, then I will look into adding this functionality also to the other backends.