Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle BadYieldError in Tornado <4.5.0 #395

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Handle BadYieldError in Tornado <4.5.0 #395

merged 1 commit into from
Mar 27, 2019

Conversation

mvollrath
Copy link
Contributor

Fixes #394

@mvollrath
Copy link
Contributor Author

The exception started being raised due to #385 but wasn't logged until #386 , this is probably why I didn't see it in my testing of the individual branches on different distros. You find all kinds of things when you actually log errors!

@mvollrath mvollrath merged commit f348fa9 into RobotWebTools:develop Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktorku viktorku viktorku approved these changes

@jihoonl jihoonl Awaiting requested review from jihoonl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvollrath @viktorku