Fix queue blocking #464
Merged
Fix queue blocking #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The thread was holding the lock while pushing to a potentially blocking function. Rewrite the logic and use a deque while we're at it.
Unit tests were sending a message of 0 which was tripping up this logic. Doesn't hurt to be explicit.
This was referenced Mar 5, 2020
|
We will test with this the coming weeks and see if the |
|
Still seems to occur, some topics are not coming in anymore. Latched topics keep old state and are not updating. |
Guarantee that the queue drops messages when blocked.
|
@jihoonl I've added a test which fails on develop to illustrate what this is doing. |
|
Sorry for late response. Looks good. I have full trust on you. thank @mvollrath! |
jihoonl
approved these changes
Apr 7, 2020
DomenicP
added a commit
to GeckoRobotics/rosbridge_suite
that referenced
this pull request
Sep 30, 2021
DomenicP
added a commit
to GeckoRobotics/rosbridge_suite
that referenced
this pull request
Sep 30, 2021
DomenicP
added a commit
to GeckoRobotics/rosbridge_suite
that referenced
this pull request
Sep 30, 2021
DomenicP
added a commit
to GeckoRobotics/rosbridge_suite
that referenced
this pull request
Oct 1, 2021
DomenicP
added a commit
to GeckoRobotics/rosbridge_suite
that referenced
this pull request
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueueMessageHandler.runwas holding onto its lock while writing out to the server. Since the websocket server can block outgoing messages now, this was causing cross-client blocking by jamming up the rospy Subscriber thread.By releasing the lock before writing, we let this handler work the way it was always intended.
The handler's internal queue was switched to a
dequefor simplicity.