Subscriber concurrency review #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent subscribe during unsubscribe critical section.
This branch must not be ignored.
jihoonl
approved these changes
Apr 8, 2020
|
👍 |
DomenicP
added a commit
to GeckoRobotics/rosbridge_suite
that referenced
this pull request
Sep 30, 2021
DomenicP
added a commit
to GeckoRobotics/rosbridge_suite
that referenced
this pull request
Sep 30, 2021
DomenicP
added a commit
to GeckoRobotics/rosbridge_suite
that referenced
this pull request
Oct 1, 2021
DomenicP
added a commit
to GeckoRobotics/rosbridge_suite
that referenced
this pull request
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect critical sections in SubscriberManager which were previously unprotected from race conditions between clients.
Raise Exception when unsubscribe input is invalid instead of passing this condition silently.