Fixed filter_globs for noetic #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Service calls with non empty requests (e.g. /rosapi/topics_for_type) were crashing due to filter's return type in python 3.
mvollrath
requested changes
May 29, 2020
rosapi/src/rosapi/glob_helper.py
Outdated
| if PYTHON2: | ||
| return filter(lambda x: any_match(x, globs), full_list) | ||
| else: | ||
| return [i for i in filter(lambda x: any_match(x, globs), full_list)] |
There was a problem hiding this comment.
Instead of having all this logic specific to Python version, the Python 3 path should work fine in Python 2 and should be the only path if that is the case.
foreignrobot
commented
May 29, 2020
|
@mvollrath is a noetic release with this fix planned in the near future (maybe for the next sync) or are there any other bugs you would like to get fixed before the next version bump? |
|
I don't see any reason not to tag a release, will do it soon after the new CI stuff is settled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service calls with non empty requests (e.g. /rosapi/topics_for_type) were crashing due to filter's return type in python 3.