Conversion between bytes and string #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of python3 sockets will input and output byte strings instead of String objects. This commits does the necessary coversions inside the tcp_handler, but it might not be the most thoughtful solution but just what I did to make it work with python3.
bionade24
approved these changes
Sep 19, 2020
mvollrath
approved these changes
Sep 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of python3 sockets will input and output byte strings instead of String objects.
This commits does the necessary coversions inside the tcp_handler, but it might
not be the most thoughtful solution but just what I did to make it work with
python3.
I tested this also on python2 and it also works there.