Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when advertising duplicate service #683

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

jtbandes
Copy link
Member

@jtbandes jtbandes commented Nov 29, 2021

Public API Changes
None

Description
Fixes an issue reported by @Stephenjerry in #650 (comment). When a duplicate service is advertised by the client, the code now correctly shuts down the original service.

There is still a WebSocketClosedError received with only a single client, when it advertises a service and then disconnects. Filed #684 to track this.

@jtbandes jtbandes merged commit 6df23d7 into ros2 Nov 29, 2021
@jtbandes jtbandes deleted the jacob/fix-duplicate-service-shutdown branch November 29, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant