Add Python3 compatibility #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoonl
requested changes
Nov 6, 2017
There was a problem hiding this comment.
thanks for PR @kartikmohta, please check a comment in the code.
| if sys.version_info >= (3, 0): | ||
| string_types = str | ||
| else: | ||
| string_types = (str, unicode) |
There was a problem hiding this comment.
Can you move this into rosbridge_library/utils/__init__.py and import from there? Then, we can avoid copy and pasting of the same functionality.
There was a problem hiding this comment.
Yes, that seems better 👍
jihoonl
approved these changes
Nov 6, 2017
Behery
pushed a commit
to Behery/rosbridge_suite
that referenced
this pull request
Jan 9, 2018
* First pass at Python 3 compatibility * message_conversion: Only call encode on a Python2 str or bytes type * protocol.py: Changes for dict in Python3. Compatible with Python 2 too. * More Python 3 fixes, all tests pass * Move definition of string_types to rosbridge_library.util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the unit tests seem to pass with both Python 2 and 3.