Fix length-limited list types #840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@achim-k can I get a review? this is a pretty brutal issue - it prevents serializing Polygons, which many planning- and geometry-related messages include. |
achim-k
reviewed
Mar 1, 2023
|
@EzraBrooks #827 looks like it does the same / something similar. Can you check that one? |
EzraBrooks
force-pushed
the
fix-list-tokens
branch
from
95228d3
to
cc80d23
Compare
|
This PR has been marked as stale because there has been no activity in the past 6 months. Please add a comment to keep it open. |
|
Got to the same solution. This solution seems ready to merge. |
|
Closing in favor of #883, which fixes this particular issue and others. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
Removes the
, Nlength specifier at the end of list types likesequence<type, length>. Fixes issues with serializingshape_msgs/Polygon, which has afloat64[<=3]field.Fixes #821