Ffmpeg 3 #43
Merged
Ffmpeg 3 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codec_context_->rc_buffer_aggressivity marked as "currently useless", so removed codec_context_->frame_skip_threshold access through new priv_data api
encode_video2 is deprecated
|
Thanks for this. I will review this right after fixing travis configuration within this week. |
jihoonl
approved these changes
Nov 20, 2017
|
I confirmed it is working xenial and kinetic. |
jihoonl
pushed a commit
that referenced
this pull request
Jan 8, 2018
* Correct use of deprecated parameters codec_context_->rc_buffer_aggressivity marked as "currently useless", so removed codec_context_->frame_skip_threshold access through new priv_data api * New names for pixel formats * AVPicture is deprecated, use AVFrame * Switch to non-deprecated free functions * Use new encoding api for newer versions encode_video2 is deprecated * codec_context is deprecated, use packet flags
This was referenced Jan 8, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build and runs on Ubuntu Xenial/ROS Kinetic and Debian Stretch/ROS lunar. The latter configuration uses ffmpeg-3.2.8.
There are a few more things deprecated (AVStream::codec) in newer ffmpeg, but they are annoying to make work on the older versions so living with the deprecation warnings for now seems reasonable.