Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design of Vehicle Dynamics feature set #144

Closed
6 tasks done
adamdbrw opened this issue Aug 11, 2022 · 5 comments · Fixed by #158
Closed
6 tasks done

Design of Vehicle Dynamics feature set #144

adamdbrw opened this issue Aug 11, 2022 · 5 comments · Fixed by #158
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@adamdbrw
Copy link
Member

adamdbrw commented Aug 11, 2022

The goal is to create Components and classes to support simulation of movement of diverse types of robot mobile bases. The focus in this task should be narrowed down to the type required by the MS2 demo (a four-wheeled, Ackermann drive type), with only rudimentary analysis of other types to understand what generalizations might be useful for the design.
This task should include the following items:

  • Domain research, including available open-source solution (PhysX vehicle Gem, others) and solutions in other simulators.
  • Design of components and classes. How would a developer use the feature?

Outcomes:

  • Document capturing useful knowledge of how this feature is designed in existing solutions, comparison of major advantages and weaknesses.
  • First design document
  • Accepted design document, after a review.
  • Finally, a set of issues capturing implementation of the proposed design (some issues can be outside of MS2).
@adamdbrw adamdbrw added the enhancement New feature or request label Aug 11, 2022
@adamdbrw adamdbrw added this to the Milestone 2 milestone Aug 11, 2022
@adamdbrw adamdbrw added this to To do in Milestone 2 Aug 11, 2022
@adamdbrw adamdbrw self-assigned this Aug 22, 2022
@adamdbrw
Copy link
Member Author

adamdbrw commented Sep 1, 2022

VehiclePhysics.pdf
First draft for reading.
This will be converted to a PR with docs
ROSVehicleDynamics_planned

@adamdbrw adamdbrw moved this from To do to In progress in Milestone 2 Sep 1, 2022
adamdbrw added a commit that referenced this issue Sep 5, 2022
Fixes #144

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>
@adamdbrw
Copy link
Member Author

adamdbrw commented Sep 5, 2022

First iteration has been submitted.
Sub-tasks will include:

  • Tasks for implementation of proposed components
  • Tests on physics scene
  • Implementation of a working example for a four-wheeled robot
  • Second iteration of design

@pawelbudziszewski
Copy link
Collaborator

It seems fine to me, I have just one question regarding the diagram: why the WheelControllerComponent is connected to the VehicleModel via WheelsConfiguration, not directly? I'm not saying this is wrong, it just seems more natural for me if these wheel-related components are swapped places.

@adamdbrw
Copy link
Member Author

adamdbrw commented Sep 6, 2022

WheelsConfiguration is a part of VehicleModel which holds (references) to WheelControllerComponents.

@pawelbudziszewski
Copy link
Collaborator

Ok for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants