New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: 4.0 #66
Merged
Merged
WIP: 4.0 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something with the way the shared contexts are organized that was causing contexts to stomp on each other and, e.g., Debian tests failing because they were trying to use RHEL settings.
This check fails when passing a `checksum` property to the `package` resource in the `chef_dk_app_windows` resource. But Chef throws a deprecation warning about `windows_package` going away if we use that to satisfy FoodCritic.
hartmantis
force-pushed
the
jdh-update-everything
branch
from
July 20, 2016 22:11
601744d
to
c7a6139
Compare
Fedora's switch to DNF makes the yum_package resource a little finnicky (and dependent on the now-addon yum package). We can circumvent that by using RPM instead.
hartmantis
force-pushed
the
jdh-update-everything
branch
from
July 21, 2016 21:23
b710889
to
82c746b
Compare
The Windows package now includes a version string in its name, not just "Chef Development Kit", so it was reinstalling on every Chef run.
As of 2016-07-24, the windows_package resource doesn't remove the app properly due to an incorrect uninstall string in its registry entry.
hartmantis
force-pushed
the
jdh-update-everything
branch
2 times, most recently
from
July 25, 2016 16:24
174921c
to
446bfaa
Compare
hartmantis
force-pushed
the
jdh-update-everything
branch
from
July 25, 2016 18:16
1a40e57
to
f376a81
Compare
hartmantis
force-pushed
the
jdh-update-everything
branch
from
July 25, 2016 18:20
f376a81
to
4591778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.