Enable frozen string literals

hartmantis · Jul 20, 2016 · 8629ee3 · 8629ee3
1 parent 907575a
commit 8629ee3
Show file tree

Hide file tree

Showing 89 changed files with 128 additions and 39 deletions.
diff --git a/Berksfile b/Berksfile
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 
 source 'https://supermarket.chef.io'
 

diff --git a/Gemfile b/Gemfile
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 
 source 'https://rubygems.org'
 

diff --git a/Guardfile b/Guardfile
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 
 guard :rspec, all_on_start: true, notification: false do
   watch(%r{^spec/.+_spec\.rb$})

diff --git a/Rakefile b/Rakefile
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 
 require 'rubygems'
 require 'bundler/setup'

diff --git a/attributes/default.rb b/attributes/default.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Attributes:: default

diff --git a/libraries/helpers.rb b/libraries/helpers.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Library:: helpers

diff --git a/libraries/matchers.rb b/libraries/matchers.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Library:: matchers

diff --git a/libraries/resource_chef_dk.rb b/libraries/resource_chef_dk.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Library:: resource_chef_dk

diff --git a/libraries/resource_chef_dk_app.rb b/libraries/resource_chef_dk_app.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Library:: resource_chef_dk_app

diff --git a/libraries/resource_chef_dk_app_debian.rb b/libraries/resource_chef_dk_app_debian.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Library:: resource_chef_dk_app_debian

diff --git a/libraries/resource_chef_dk_app_mac_os_x.rb b/libraries/resource_chef_dk_app_mac_os_x.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Library:: resource_chef_dk_app_mac_os_x

diff --git a/libraries/resource_chef_dk_app_rhel.rb b/libraries/resource_chef_dk_app_rhel.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Library:: resource_chef_dk_app_rhel

diff --git a/libraries/resource_chef_dk_app_windows.rb b/libraries/resource_chef_dk_app_windows.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Library:: resource_chef_dk_app_windows

diff --git a/libraries/resource_chef_dk_gem.rb b/libraries/resource_chef_dk_gem.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Library:: resource_chef_dk_gem

diff --git a/libraries/resource_chef_dk_shell_init.rb b/libraries/resource_chef_dk_shell_init.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Library:: resource_chef_dk_shell_init

diff --git a/libraries/resource_chef_dk_shell_init_debian.rb b/libraries/resource_chef_dk_shell_init_debian.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Library:: resource_chef_dk_shell_init_debian

diff --git a/libraries/resource_chef_dk_shell_init_mac_os_x.rb b/libraries/resource_chef_dk_shell_init_mac_os_x.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Library:: resource_chef_dk_shell_init_mac_os_x

diff --git a/libraries/resource_chef_dk_shell_init_rhel.rb b/libraries/resource_chef_dk_shell_init_rhel.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Library:: resource_chef_dk_shell_init_rhel

diff --git a/metadata.rb b/metadata.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 
 name 'chef-dk'
 maintainer 'Jonathan Hartman'

diff --git a/recipes/default.rb b/recipes/default.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 #
 # Cookbook Name:: chef-dk
 # Recipe:: default

diff --git a/spec/libraries/helpers_spec.rb b/spec/libraries/helpers_spec.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../../libraries/helpers'

diff --git a/spec/recipes/default_spec.rb b/spec/recipes/default_spec.rb
@@ -1,4 +1,5 @@
-# Encoding: UTF-8
+# encoding: utf-8
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 

diff --git a/spec/resources.rb b/spec/resources.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'spec_helper'
 
 shared_context 'resources' do

diff --git a/spec/resources/chef_dk.rb b/spec/resources/chef_dk.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../resources'
 require_relative '../../libraries/helpers'
 

diff --git a/spec/resources/chef_dk/centos/6_8_spec.rb b/spec/resources/chef_dk/centos/6_8_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../chef_dk'
 
 describe 'resources::chef_dk::centos::6_8' do

diff --git a/spec/resources/chef_dk/centos/7_2_1511_spec.rb b/spec/resources/chef_dk/centos/7_2_1511_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../chef_dk'
 
 describe 'resources::chef_dk::centos::7_2_1511' do

diff --git a/spec/resources/chef_dk/debian/8_4_spec.rb b/spec/resources/chef_dk/debian/8_4_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../chef_dk'
 
 describe 'resources::chef_dk::debian::8_4' do

diff --git a/spec/resources/chef_dk/fedora/23_spec.rb b/spec/resources/chef_dk/fedora/23_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../chef_dk'
 
 describe 'resources::chef_dk::fedora::23' do

diff --git a/spec/resources/chef_dk/mac_os_x/10_10_spec.rb b/spec/resources/chef_dk/mac_os_x/10_10_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../chef_dk'
 
 describe 'resources::chef_dk::mac_os_x::10_10' do

diff --git a/spec/resources/chef_dk/redhat/7_1_spec.rb b/spec/resources/chef_dk/redhat/7_1_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../chef_dk'
 
 describe 'resources::chef_dk::redhat::7_1' do

diff --git a/spec/resources/chef_dk/ubuntu/14_04_spec.rb b/spec/resources/chef_dk/ubuntu/14_04_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../chef_dk'
 
 describe 'resources::chef_dk::ubuntu::14_04' do

diff --git a/spec/resources/chef_dk/ubuntu/16_04_spec.rb b/spec/resources/chef_dk/ubuntu/16_04_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../chef_dk'
 
 describe 'resources::chef_dk::ubuntu::16_04' do

diff --git a/spec/resources/chef_dk/windows/10_spec.rb b/spec/resources/chef_dk/windows/10_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../chef_dk'
 
 describe 'resources::chef_dk::windows::10' do

diff --git a/spec/resources/chef_dk_app.rb b/spec/resources/chef_dk_app.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../resources'
 require_relative '../../libraries/helpers'
 

diff --git a/spec/resources/chef_dk_app/centos/6_8_spec.rb b/spec/resources/chef_dk_app/centos/6_8_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../rhel'
 
 describe 'resources::chef_dk_app::centos::6_8' do

diff --git a/spec/resources/chef_dk_app/centos/7_2_1511_spec.rb b/spec/resources/chef_dk_app/centos/7_2_1511_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../rhel'
 
 describe 'resources::chef_dk_app::centos::7_2_1511' do

diff --git a/spec/resources/chef_dk_app/debian.rb b/spec/resources/chef_dk_app/debian.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../chef_dk_app'
 
 shared_context 'resources::chef_dk_app::debian' do

diff --git a/spec/resources/chef_dk_app/debian/8_4_spec.rb b/spec/resources/chef_dk_app/debian/8_4_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../debian'
 
 describe 'resources::chef_dk_app::debian::8_4' do

diff --git a/spec/resources/chef_dk_app/fedora/23_spec.rb b/spec/resources/chef_dk_app/fedora/23_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../rhel'
 
 describe 'resources::chef_dk_app::fedora::23' do

diff --git a/spec/resources/chef_dk_app/mac_os_x.rb b/spec/resources/chef_dk_app/mac_os_x.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../chef_dk_app'
 
 shared_context 'resources::chef_dk_app::mac_os_x' do

diff --git a/spec/resources/chef_dk_app/mac_os_x/10_10_spec.rb b/spec/resources/chef_dk_app/mac_os_x/10_10_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../mac_os_x'
 
 describe 'resources::chef_dk_app::mac_os_x::10_10' do

diff --git a/spec/resources/chef_dk_app/redhat/7_1_spec.rb b/spec/resources/chef_dk_app/redhat/7_1_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../rhel'
 
 describe 'resources::chef_dk_app::redhat::7_1' do

diff --git a/spec/resources/chef_dk_app/rhel.rb b/spec/resources/chef_dk_app/rhel.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../chef_dk_app'
 
 shared_context 'resources::chef_dk_app::rhel' do

diff --git a/spec/resources/chef_dk_app/ubuntu/14_04_spec.rb b/spec/resources/chef_dk_app/ubuntu/14_04_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../debian'
 
 describe 'resources::chef_dk_app::ubuntu::14_04' do

diff --git a/spec/resources/chef_dk_app/ubuntu/16_04_spec.rb b/spec/resources/chef_dk_app/ubuntu/16_04_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../debian'
 
 describe 'resources::chef_dk_app::ubuntu::16_04' do

diff --git a/spec/resources/chef_dk_app/windows.rb b/spec/resources/chef_dk_app/windows.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../chef_dk_app'
 
 shared_context 'resources::chef_dk_app::windows' do

diff --git a/spec/resources/chef_dk_app/windows/10_spec.rb b/spec/resources/chef_dk_app/windows/10_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../windows'
 
 describe 'resources::chef_dk_app::windows::10' do

diff --git a/spec/resources/chef_dk_gem.rb b/spec/resources/chef_dk_gem.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../resources'
 
 shared_context 'resources::chef_dk_gem' do

diff --git a/spec/resources/chef_dk_gem/centos/6_8_spec.rb b/spec/resources/chef_dk_gem/centos/6_8_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../linux'
 
 describe 'resources::chef_dk_gem::centos::6_8' do

diff --git a/spec/resources/chef_dk_gem/centos/7_2_1511_spec.rb b/spec/resources/chef_dk_gem/centos/7_2_1511_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../linux'
 
 describe 'resources::chef_dk_gem::centos::7_2_1511' do

diff --git a/spec/resources/chef_dk_gem/debian/8_4_spec.rb b/spec/resources/chef_dk_gem/debian/8_4_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../linux'
 
 describe 'resources::chef_dk_gem::debian::8_4' do

diff --git a/spec/resources/chef_dk_gem/fedora/23_spec.rb b/spec/resources/chef_dk_gem/fedora/23_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../linux'
 
 describe 'resources::chef_dk_gem::fedora::23' do

diff --git a/spec/resources/chef_dk_gem/linux.rb b/spec/resources/chef_dk_gem/linux.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../chef_dk_gem'
 
 shared_context 'resources::chef_dk_gem::linux' do

diff --git a/spec/resources/chef_dk_gem/mac_os_x/10_10_spec.rb b/spec/resources/chef_dk_gem/mac_os_x/10_10_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../linux'
 
 describe 'resources::chef_dk_gem::mac_os_x::10_10' do

diff --git a/spec/resources/chef_dk_gem/redhat/7_1_spec.rb b/spec/resources/chef_dk_gem/redhat/7_1_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../linux'
 
 describe 'resources::chef_dk_gem::redhat::7_1' do

diff --git a/spec/resources/chef_dk_gem/ubuntu/14_04_spec.rb b/spec/resources/chef_dk_gem/ubuntu/14_04_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../linux'
 
 describe 'resources::chef_dk_gem::ubuntu::14_04' do

diff --git a/spec/resources/chef_dk_gem/ubuntu/16_04_spec.rb b/spec/resources/chef_dk_gem/ubuntu/16_04_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../linux'
 
 describe 'resources::chef_dk_gem::ubuntu::16_04' do

diff --git a/spec/resources/chef_dk_gem/windows.rb b/spec/resources/chef_dk_gem/windows.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../chef_dk_gem'
 
 shared_context 'resources::chef_dk_gem::windows' do

diff --git a/spec/resources/chef_dk_gem/windows/10_spec.rb b/spec/resources/chef_dk_gem/windows/10_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../windows'
 
 describe 'resources::chef_dk_gem::windows::10' do

diff --git a/spec/resources/chef_dk_shell_init.rb b/spec/resources/chef_dk_shell_init.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../resources'
 
 shared_context 'resources::chef_dk_shell_init' do
@@ -17,7 +18,7 @@
       # Here is a
       # bashrc
     EOH
-    content << "\neval \"$(chef shell-init bash)\"" if enabled?
+    content = "#{content}\neval \"$(chef shell-init bash)\"" if enabled?
     allow(File).to receive(:exist?).and_call_original
     allow(File).to receive(:exist?).with(
       name == 'root' ? root_bashrc : user_bashrc

diff --git a/spec/resources/chef_dk_shell_init/centos/6_8_spec.rb b/spec/resources/chef_dk_shell_init/centos/6_8_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../rhel'
 
 describe 'resources::chef_dk_shell_init::centos::6_8' do

diff --git a/spec/resources/chef_dk_shell_init/centos/7_2_1511_spec.rb b/spec/resources/chef_dk_shell_init/centos/7_2_1511_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../rhel'
 
 describe 'resources::chef_dk_shell_init::centos::7_2_1511' do

diff --git a/spec/resources/chef_dk_shell_init/debian.rb b/spec/resources/chef_dk_shell_init/debian.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../chef_dk_shell_init'
 
 shared_context 'resources::chef_dk_shell_init::debian' do

diff --git a/spec/resources/chef_dk_shell_init/debian/8_4_spec.rb b/spec/resources/chef_dk_shell_init/debian/8_4_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../debian'
 
 describe 'resources::chef_dk_shell_init::debian::8_4' do

diff --git a/spec/resources/chef_dk_shell_init/fedora/23_spec.rb b/spec/resources/chef_dk_shell_init/fedora/23_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../rhel'
 
 describe 'resources::chef_dk_shell_init::fedora::23' do

diff --git a/spec/resources/chef_dk_shell_init/mac_os_x.rb b/spec/resources/chef_dk_shell_init/mac_os_x.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../chef_dk_shell_init'
 
 shared_context 'resources::chef_dk_shell_init::mac_os_x' do

diff --git a/spec/resources/chef_dk_shell_init/mac_os_x/10_10_spec.rb b/spec/resources/chef_dk_shell_init/mac_os_x/10_10_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../mac_os_x'
 
 describe 'resources::chef_dk_shell_init::mac_os_x::10_10' do

diff --git a/spec/resources/chef_dk_shell_init/redhat/7_1_spec.rb b/spec/resources/chef_dk_shell_init/redhat/7_1_spec.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../rhel'
 
 describe 'resources::chef_dk_shell_init::redhat::7_1' do

diff --git a/spec/resources/chef_dk_shell_init/rhel.rb b/spec/resources/chef_dk_shell_init/rhel.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../chef_dk_shell_init'
 
 shared_context 'resources::chef_dk_shell_init::rhel' do