Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noetic Support #4

Open
rafa-martin opened this issue Jul 3, 2023 · 6 comments
Open

Noetic Support #4

rafa-martin opened this issue Jul 3, 2023 · 6 comments
Assignees

Comments

@rafa-martin
Copy link
Member

I tried to compile 91b5e92 commit.

camera_info_manager_py package isn't in rosdistro.

$ catkin build axis_camera 
----------------------------------------------------------
Profile:                     default
Extending:          [cached] /opt/ros/noetic
Workspace:                   /home/robot/catkin_ws
----------------------------------------------------------
Build Space:        [exists] /home/robot/catkin_ws/build
Devel Space:        [exists] /home/robot/catkin_ws/devel
Install Space:      [unused] /home/robot/catkin_ws/install
Log Space:          [exists] /home/robot/catkin_ws/logs
Source Space:       [exists] /home/robot/catkin_ws/src
DESTDIR:            [unused] None
----------------------------------------------------------
Devel Space Layout:          linked
Install Space Layout:        None
----------------------------------------------------------
Additional CMake Args:       -DCMAKE_BUILD_TYPE=Release
Additional Make Args:        None
Additional catkin Make Args: None
Internal Make Job Server:    True
Cache Job Environments:      False
----------------------------------------------------------
Buildlisted Packages:        None
Skiplisted Packages:         None
----------------------------------------------------------
Workspace configuration appears valid.
----------------------------------------------------------
[build] Found 205 packages in 0.0 seconds.                                                                                                                                                                 
[build] Package table is up to date.                                                                                                                                                                       
Starting  >>> robotnik_msgs                                                                                                                                                                                
Finished  <<< robotnik_msgs                [ 0.9 seconds ]                                                                                                                                                 
Starting  >>> axis_camera                                                                                                                                                                                  
___________________________________________________________________________________________________________________________________________________________________________________________________________
Errors     << axis_camera:cmake /home/robot/catkin_ws/logs/axis_camera/build.cmake.001.log                                                                                                                 
CMake Warning (dev) at CMakeLists.txt:2 (project):
  Policy CMP0048 is not set: project() command manages VERSION variables.
  Run "cmake --help-policy CMP0048" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  The following variable(s) would be set to empty:

    CMAKE_PROJECT_VERSION
    CMAKE_PROJECT_VERSION_MAJOR
    CMAKE_PROJECT_VERSION_MINOR
    CMAKE_PROJECT_VERSION_PATCH
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Error at /opt/ros/noetic/share/catkin/cmake/catkinConfig.cmake:83 (find_package):
  Could not find a package configuration file provided by
  "camera_info_manager_py" with any of the following names:

    camera_info_manager_pyConfig.cmake
    camera_info_manager_py-config.cmake

  Add the installation prefix of "camera_info_manager_py" to
  CMAKE_PREFIX_PATH or set "camera_info_manager_py_DIR" to a directory
  containing one of the above files.  If "camera_info_manager_py" provides a
  separate development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
  CMakeLists.txt:4 (find_package)


cd /home/robot/catkin_ws/build/axis_camera; catkin build --get-env axis_camera | catkin env -si  /usr/bin/cmake /home/robot/catkin_ws/src/summit_packages/sensors/axis_camera --no-warn-unused-cli -DCATKIN_DEVEL_PREFIX=/home/robot/catkin_ws/devel/.private/axis_camera -DCMAKE_INSTALL_PREFIX=/home/robot/catkin_ws/install -DCMAKE_BUILD_TYPE=Release; cd -

...........................................................................................................................................................................................................
Failed     << axis_camera:cmake            [ Exited with code 1 ]                                                                                                                                          
Failed    <<< axis_camera                  [ 0.6 seconds ]                                                                                                                                                 
[build] Summary: 1 of 2 packages succeeded.                                                                                                                                                                
[build]   Ignored:   203 packages were skipped or are skiplisted.                                                                                                                                          
[build]   Warnings:  None.                                                                                                                                                                                 
[build]   Abandoned: None.                                                                                                                                                                                 
[build]   Failed:    1 packages failed.                                                                                                                                                                    
[build] Runtime: 1.7 seconds total.     
@jamendezib
Copy link
Contributor

There isn't a rosdep key for camera_info_manager_py in Noetic yet.
To avoid this error, clone the camera_info_manager_py in your catkin workspace and compile again:
git clone https://github.com/RobotnikAutomation/camera_info_manager_py.git

@jamendezib
Copy link
Contributor

The package has been updated to work with noetic in the branch "noetic-devel"

@rafa-martin
Copy link
Member Author

So, is it necessary to clone RobotnikAutomation/camera_info_manager_py.git package?

@jamendezib
Copy link
Contributor

Yes

@rafa-martin
Copy link
Member Author

It would be interesting to check if camera_info_manager_py is truly necessary in this package.

If it is needed, we should verify if it's used in another repository or if it can be included in this one. This way, we minimize the number of packages and ensure they are self-contained. It makes it easier to manage and migrate.

@jamendezib
Copy link
Contributor

From what I have seen, the only camera that uses camera_info_manager_py is the axis, so maybe we could do as you say

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants