Add response interceptors #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattKiazyk
approved these changes
Jul 6, 2022
| @@ -17,6 +17,9 @@ public protocol AsyncNetworkService: AnyObject { | |||
|
|
|||
| /// if this is set, all network requests returned with an error will loop through the list. | |||
| var errorHandlers: [AsyncNetworkErrorHandler] { get set } | |||
|
|
|||
| /// if this is set, all network reponses returned with success will call `handle` on these interceptors | |||
| var reponseInterceptors: [NetworkResponseInterceptor] { get set } | |||
There was a problem hiding this comment.
Suggested change
| var reponseInterceptors: [NetworkResponseInterceptor] { get set } | |
| var responseInterceptors: [NetworkResponseInterceptor] { get set } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original idea comes from Apollo Interceptors where the network service allows external introspection of request before the are handed over to the original caller. This allows the calling framework to centrally react to all responses which may contain the same data values within multiple endpoints (e.g access token structures attached to various types of response models). The idea is the interceptor would observe the response data and request that was originally made and then decide weather it contains a central data item that needs or even if the response needs to be modified to enforce a lack congruity on the back-end.