This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Fix for cert verify in Go 1.10 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Go 1.10 returns: certificate specifies an incompatible key usage: asn1.ObjectIdentifier{1, 3, 6, 1, 5, 5, 7, 3, 1} for APNS cert. This code change will catch and ignore this error.
|
I am not sure why travis failed to build. I have tested this locally back to 1.7.5 |
|
This is the TravisCI failure: |
|
It looks like the cert used in the test has expired. This is irrelevant of the code change. |
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
- Coverage 56.16% 55.88% -0.29%
==========================================
Files 11 11
Lines 308 306 -2
==========================================
- Hits 173 171 -2
Misses 116 116
Partials 19 19
Continue to review full report at Codecov.
|
|
@nathany I updated the expired cert to a valid one. The tests now pass. |
|
Thank you Ken! |
cheungpat
pushed a commit
to SkygearIO/buford
that referenced
this pull request
May 11, 2018
* Fix for Go 1.10
In Go 1.10 returns: certificate specifies an incompatible key usage: asn1.ObjectIdentifier{1, 3, 6, 1, 5, 5, 7, 3, 1} for APNS cert. This code change will catch and ignore this error.
* update expired cert for test
* remove .idea files
* add golang 1.10 to travis test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Go 1.10 returns: certificate specifies an incompatible key usage: asn1.ObjectIdentifier{1, 3, 6, 1, 5, 5, 7, 3, 1} for APNS cert. This code change will catch and ignore this error.