This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 69
Add github flavored markdown table implementation. #12
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
"""Test end to end showing Github flavored markdown table.""" | ||
|
||
from terminaltables import GithubFlavoredMarkdownTable | ||
|
||
|
||
def test_simple(): | ||
"""Simple GithubFlavoredMarkdownTable test.""" | ||
table_data = [ | ||
['Name', 'Color', 'Type'], | ||
['Avocado', 'green', 'nut'], | ||
['Tomato', 'red', 'fruit'], | ||
['Lettuce', 'green', 'vegetable'], | ||
] | ||
table = GithubFlavoredMarkdownTable(table_data) | ||
|
||
expected = ( | ||
'| Name | Color | Type |\n' | ||
'|---------|-------|-----------|\n' | ||
'| Avocado | green | nut |\n' | ||
'| Tomato | red | fruit |\n' | ||
'| Lettuce | green | vegetable |' | ||
) | ||
assert expected == table.table | ||
|
||
table.justify_columns[0] = 'center' | ||
expected = ( | ||
'| Name | Color | Type |\n' | ||
'|:-------:|-------|-----------|\n' | ||
'| Avocado | green | nut |\n' | ||
'| Tomato | red | fruit |\n' | ||
'| Lettuce | green | vegetable |' | ||
) | ||
assert expected == table.table | ||
|
||
table.justify_columns[1] = 'left' | ||
expected = ( | ||
'| Name | Color | Type |\n' | ||
'|:-------:|:------|-----------|\n' | ||
'| Avocado | green | nut |\n' | ||
'| Tomato | red | fruit |\n' | ||
'| Lettuce | green | vegetable |' | ||
) | ||
assert expected == table.table | ||
|
||
table.justify_columns[2] = 'right' | ||
expected = ( | ||
'| Name | Color | Type |\n' | ||
'|:-------:|:------|----------:|\n' | ||
'| Avocado | green | nut |\n' | ||
'| Tomato | red | fruit |\n' | ||
'| Lettuce | green | vegetable |' | ||
) | ||
assert expected == table.table |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Robpol86 CI warns for this issue:
W:106, 4: __init__ method from base class 'BaseTable' is not called (super-init-not-called)
, but I think there is no need to call the super here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should still stick super() it in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Robpol86 ok, fixed now.