Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iTerm2 support #21

Closed
saiichihashimoto opened this issue Jan 13, 2018 · 3 comments
Closed

iTerm2 support #21

saiichihashimoto opened this issue Jan 13, 2018 · 3 comments

Comments

@saiichihashimoto
Copy link

I'm currently using iTerm2 rather than terminal and both the activateTerminalOnError and onClick opens a new Terminal (not ideal).

So two questions:

  • Can iTerm2 be supported by default? And, if not,
  • What's the quickest path to me solving this in my own project (ie is there a parameter for which application gets opened that I can change)?
@saiichihashimoto
Copy link
Author

Keeping in mind that my coworkers don't use iTerm2 and use the default Terminal.

@RoccoC
Copy link
Owner

RoccoC commented Jan 14, 2018

We can fix this. Definitely should add a config option (or somehow figure out the spawning app) rather than hardcode to terminal.

@saiichihashimoto
Copy link
Author

That would be great! It would be ideal if it detected which one so the command could work for all of us!

blvz added a commit to blvz/webpack-build-notifier that referenced this issue Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants