Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread ID as default log entry property #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkrmo
Copy link
Contributor

@jkrmo jkrmo commented Sep 29, 2022

Description

#109
Having the ThreadID as a default extended property on the log entry would be helpful and I don't think it would ever hurt anything.

I thought about where this addition could go - the log processor makes sense, but if a background processor is in place, the value won't be accurate. I also thought it could go on the Logger instance, but then custom implementations may not inherit this nicety.

Am curious on feedback or opinions on this type of addition.

Type of change:

  1. New feature (non-breaking change that adds functionality)

Checklist:

  • Have you reviewed your own code? Do you understand every change?
  • Are you following the contributing guidelines?
  • Have you added tests that prove your fix is effective or that this feature works?
  • New and existing unit tests pass locally with these changes?
  • Have you made corresponding changes to the documentation?
  • Will this change require an update to an example project? (if so, create an issue and link to it)

Reviewer guidelines

@kristycurrier
Copy link
Member

Let's open a discussion to talk about this, having a related issue is important.

@jkrmo
Copy link
Contributor Author

jkrmo commented Oct 4, 2022

Let's open a discussion to talk about this, having a related issue is important.

Sure - i've created #109 as a discussion point for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants