This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
Fix bugs in static constructor #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 13, 2019 11:36
In .NET Core 2.1 and above, the signature of the TypeArguments property of the internal ICSharpInvokeOrInvokeMemberBinder interface changed from IList<Type> to Type[]. What this boils down to is that generic arguments were not being captured in a small number of cases. In the .NET Core 3.0, static readonly fields are enforced by reflection. This caused the static constructor of UniversalMemberAccessor to throw a TypeInitializationException when it performed feature detection on whether modifying readonly fields is supported. The solution is to wrap the feature detection in try/catch blocks.
JustinMoss
approved these changes
Nov 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In .NET Core 2.1 and above, the signature of the
TypeArgumentsproperty of the internalICSharpInvokeOrInvokeMemberBinderinterface changed fromIList<Type>toType[]. What this boils down to is that generic arguments were not being captured in a small number of cases.In .NET Core 3.0, static readonly fields are enforced by reflection. This caused the static constructor of UniversalMemberAccessor to throw a TypeInitializationException when it performed feature detection on whether modifying readonly fields is supported. The solution is to wrap the feature detection in try/catch blocks.