Implement PageTitleMixin #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-galligan
approved these changes
Jul 13, 2021
bonniegee
approved these changes
Jul 14, 2021
|
I'm seeing all those great page titles showing up except in the |
|
good catch @HaSistrunk - that latest commit should have fixed that. |
I can't figure out why, because this fix makes sense to me, but I'm still seeing just "Aurora" in the |
|
Hmm, I can't reproduce that. Did you try clearing your browser cache?
|
|
Cache was cleared, turns out it was some git chaos I created for myself locally that I won't bore you with. All good! |
HaSistrunk
approved these changes
Jul 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a PageTitleMixin and implements it across the application. This means that all pages now have a meta page title which aligns with the
h1on the page. It also allowed me to get rid of someget_context_datablocks in views, which was a nice feeling.Asking for a review on this because it's fairly invasive.
Fixes #473