-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PageTitleMixin #482
Conversation
I'm seeing all those great page titles showing up except in the |
good catch @HaSistrunk - that latest commit should have fixed that. |
I can't figure out why, because this fix makes sense to me, but I'm still seeing just "Aurora" in the |
Cache was cleared, turns out it was some git chaos I created for myself locally that I won't bore you with. All good! |
Adds a PageTitleMixin and implements it across the application. This means that all pages now have a meta page title which aligns with the
h1
on the page. It also allowed me to get rid of someget_context_data
blocks in views, which was a nice feeling.Asking for a review on this because it's fairly invasive.
Fixes #473