Prevent endless authentication loop for logged out users #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helrond
reviewed
Jun 10, 2020
Co-authored-by: Hillel Arnold <helrond@hotmail.com>
helrond
approved these changes
Jun 11, 2020
bonniegee
approved these changes
Jun 11, 2020
p-galligan
approved these changes
Jun 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #413
Changes LoginRequiredMixin
login_urlparameter from/appto/loginto prevent endless redirection when a logged out user tries to get to the site using the/appurl (like if they have bookmarked the site while logged in).