Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets up continuous deployment for development #279

Merged
merged 131 commits into from May 19, 2020
Merged

Sets up continuous deployment for development #279

merged 131 commits into from May 19, 2020

Conversation

helrond
Copy link
Member

@helrond helrond commented May 18, 2020

Sets up CD for development branch:

  • Adds appspec.yml and associated deployment scripts
  • Updates .travis.yml to trigger builds
  • Refactors handling of configs to support setting of env variables in in Travis
  • Slimming build as much as possible by removing unnecessary static files and build artifacts

@helrond helrond changed the title Development Sets up continuous deployment for development May 18, 2020
Copy link

@bonniegee bonniegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I looked closely at the bash scripts, and don't have suggestions for them to be simplified.

@p-galligan
Copy link
Member

Yeah, I think the documentation is generally pretty good. I would echo that I didn't come up with anything better for the bash scripts, but I've never been the best at those in general.

@helrond helrond merged commit f00aae7 into master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants