Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Create Notion Database From RocketChat For Properties Without Configuration #14

Merged
merged 30 commits into from
Jul 7, 2023
Merged

[Feat] Create Notion Database From RocketChat For Properties Without Configuration #14

merged 30 commits into from
Jul 7, 2023

Conversation

Nabhag8848
Copy link
Collaborator

@Nabhag8848 Nabhag8848 commented Jun 12, 2023 •
edited
Loading

Issue(s)

Acceptance Criteria fulfillment

  • register /notion create database command
  • Have Helper Methods for UI under ElementBuilder and BlockBuilder for StaticSelectMenu, OverflowMenu, InputElement, DividerBlock
  • Create Methods: createNotionDatabase and SearchPages Under NotionSdk
  • Create Reusable methods SearchPageComponent, DropDownComponent, ButtonInSectionComponent, InputElementComponent.
  • Create ModalInteraction Class which includes methods for Store/Clear/Get actionIds and Methods for Storing Pages during Interaction of modals.
  • Have Add and Remove Property Block Interaction by storing and removing ActionsId mechanism.

Proposed changes (including videos or screenshots)

Further comments

  • This PR includes the basic implements of the Create Notion Database with properties having no configuration with expection of Number getting as a default field type number. There is no handling of required parameters but optional params are handled. The Notification once database is created succesfully or not will be further configured in addup PR and Type of CreateNotionDatabase under NotionSDK will be created in addup PR too

@Nabhag8848 Nabhag8848 marked this pull request as ready for review June 17, 2023 11:26
@Nabhag8848 Nabhag8848 changed the title [Feat] Create Notion Database From RocketChat [Feat] Create Notion Database From RocketChat For Properties Without Configuration Jun 17, 2023
@Nabhag8848 Nabhag8848 mentioned this pull request Jun 19, 2023
Merged
6 tasks
@Nabhag8848
feat: created IHandler and Handler Class
efc4157
@Nabhag8848
feat: registered create database command using handler
d897781
@Nabhag8848
feat: created helper methods for dropdown element
8e002d2
@Nabhag8848
feat: registered and implemented searchPages() in NotionSDK
b48f623
@Nabhag8848
feat: registered and Implemented createInputBlock() for SearchPageCom…
e506fb6 
…ponent
@Nabhag8848
feat: created reusable searchPageComponent() method
3082b98
@Nabhag8848
feat: registered and Implemented createPlainTextInput() Element
f728dde
@Nabhag8848
fix: searchPageComponent label to look alike mandatory field
7570abb
@Nabhag8848
feat(ui): created reusable inputElementComponent
c6fd876
@Nabhag8848
feat(ui): created reusable buttonInSectionComponent()
5f42d84
@Nabhag8848
feat(ui): created and registered ViewClosed and ViewSubmit Handler
d0fbe8c
@Nabhag8848
feat(ui): created, registered BlockAction Handler and refactored bloc…
130115b 
…k actions
@Nabhag8848
fix: parameter type of InputElementComponent
e4456b7
@Nabhag8848
feat: created ModalInteractionStorage for storing Objects
7f17c7e
@Nabhag8848
feat(ui): created reusable DropDownComponent()
0750cad
@Nabhag8848
feat: created getPropertyTypes() for PropertyType Dropdown
fd9a32d
@Nabhag8848
fix: RoomInteractionStorage design to avoid passing UserId in methods
f05db96
@Nabhag8848
feat: created reusable methods to clearAllStorageInteraction and gene…
6b5379f 
…rate UUID
@Nabhag8848
feat: created get/store/clear interaction pagesOrDatabase method
9e06dfd
@Nabhag8848
fix: searchPageComponent to fetch Pages only Once during Interaction
6cf7b53
@Nabhag8848
feat: created Basic CreateNotionDatabase Modal
581fc40 
Description: Includes Handling of Add Property and Removing Property also clearing All Interactions including Pages Interaction
@Nabhag8848
feat: sendNotification with ConnectBlock when user Not Authorized
c2090d2
@Nabhag8848
feat: added connectPreviewLayout within CreateDatabaseModal
0ea8019
@Nabhag8848
fix: auth messages to have it in enums instead of string
7185604
@Nabhag8848
feat: created createDividerBlock() && createOverflowElement()
028db03
@Nabhag8848
feat: added divider above and below each added property
9653fcd
@Nabhag8848
fix: StaticSelectElement to have dispatchActions
1ec6cfa
@Nabhag8848
fix: createNotionDatabaseModal to clearInteractionOnAnyClose
b15a78d
@Nabhag8848
feat: create database with properties without configuration
053c589 
Description: This PR includes the basic implements of the Create Notion Database with properties havhing not configuration with expection of Number getting as a default field type number. There is no handling of required parameters but optional params are handled. The Notification once database is created succesfully or not will be configured in addup PR and Type of CreateNotionDatabase under NotionSDK will be created in addup PR too
@Nabhag8848
fix: divider to not repeat above each propertyblock
d8d3506
@Nabhag8848 Nabhag8848 mentioned this pull request Jun 27, 2023
Closed
12 tasks
samad-yar-khan
samad-yar-khan approved these changes Jul 7, 2023
View reviewed changes
enum/CommandParam.ts
}

export enum SubCommandParam {
DATABASE = "database",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

db can also be a quick command

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do this in a consecutive PR

src/handlers/ExecuteViewSubmitHandler.ts Show resolved Hide resolved
samad-yar-khan
samad-yar-khan approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@samad-yar-khan samad-yar-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samad-yar-khan samad-yar-khan merged commit 402e719 into RocketChat:main Jul 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samad-yar-khan samad-yar-khan samad-yar-khan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] Create Notion Database From RocketChat
2 participants
@Nabhag8848 @samad-yar-khan