-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Create Notion Record From RC #22
[Feat] Create Notion Record From RC #22
Conversation
f632af6
to
e089eec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nabhag8848 left some comments
ADD_PROPERTY_ACTION = "add-property-create-page-or-record-action-id", | ||
ADD_PROPERTY_BLOCK = "add-property-create-page-or-record-action-id", | ||
ADD_PROPERTY_BUTTON_TEXT = "Add Property", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nabhag8848 Are these not needed anymore ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope! these are not needed as we had transition to new implementation. before it was having add and remove but now we just get all the components as user selects notion table.
); | ||
]; | ||
|
||
const missingObject = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nabhag8848 empty constant missing object ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to missingPropObject to make it more meaningful. its being used for view errors when user misses the required property to input.
Related to #22 (comment)
missingObject[ | ||
NotionPageOrRecord.TITLE_ACTION | ||
] = `Please Provide ${titleViewError}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nabhag8848 you are updating a constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have used assignment immutablity in this case. const missingObject = { } is making sure reference to that object doesn't change.
Just shared the below example showing what i mean.
we can see object1 has also been changed due to change in missingObject as we have a constant reference when changing its changing the existing object not the referrence.
Issue(s)
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)
Further comments