You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make changes to searchPage and searchDatabase methods.
Proposed changes (including videos or screenshots):
Made changes to searchPage method. Now, we are getting all the pages made in a workspace. Screenshot of the length of the final results after concatenating all the response.data.results
brf153
changed the title
[ Feat ]: Added recursive function for searchPages
[ Feat ]: Added recursive function for Pages and Databases
Jan 22, 2024
brf153
changed the title
[ Feat ]: Added recursive function for Pages and Databases
[Feat]: Introducing Pagination Support for Notion API in Page and Database Responses
Jan 22, 2024
@Nabhag8848 I have implemented changes that enable paginated responses for searchPages, searchDatabases, and searchPagesAndDatabases. Also, I need your help. I have successfully retrieved all the pages and databases from the response (verified in the terminal). However, I am facing an issue: when making a /notion create, /notion create db, or /notion share request, the dialog box does not appear on the screen. I'm unsure if this is a server error or an issue with my system. Could you please review these changes on your system? I made modifications in the Notion SDK file. Apologies for any inconvenience caused.
@Nabhag8848 I've implemented the changes, and while there might be occasional delays in responses, we are consistently receiving them. I'm not sure if it's a system issue or another factor. Could you please check it on your end? I appreciate your understanding, and I'm confident we'll resolve any minor hiccups.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brf153
changed the title
Issue(s)
closes #38
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots):
Made changes to searchPage method. Now, we are getting all the pages made in a workspace.
Screenshot of the length of the final results after concatenating all the response.data.results