-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve release process #61
Comments
@geekgonecrazy the best way would be to merge both repos I guess. |
cc: @sampaiodiego Yes this is exactly what i'm wondering if could be possible. Do you have any details of how the build is triggered? Would be amazing if we could tie directly into our release process. |
Hey, sorry for missing this earlier -- I think https://github.com/docker-library/official-images is the best place to get back up to speed on what the Official Images process is. The only additional bit above what's documented there that this repository has is @docker-library-bot running We'd certainly appreciate this repository/image getting more attention and active maintenance than it current does. 👍 🎉 (cc @yosifkit for visibility) |
I would like to pay your attention that building of new releases in official version of Rocket chat are still not working. |
If i'm understanding this correctly.
@sampaiodiego that sound accurate? We already do this for our snaps |
@geekgonecrazy so the idea is to remove this repo and use only our main one? to do so we would then move all files from here to a folder is that the plan? I thought we actually need a new repo to host the official image. |
It doesn't have to be a separate repo, but if you put it in your main repo and couple it tightly with your main release process then it usually becomes harder to make non-release-related changes (script fixes/updates, |
(Also, in our review, we review the whole "context" of the image, so please don't put it at the root of the main source repo and use |
I'm not sure... 🤔 I didn't realize the requirement of only depending on other official images. Maybe instead we just bump this repo from our CI instead. Since we have no choice but to maintain 2 different docker images 😶 |
we might need to do this.. for some reason @docker-library-bot didn't run the past two releases. @tianon do you happen to know why? tia |
It didn't run because the access for @docker-library-bot to push was revoked so we removed the job: docker-library/oi-janky-groovy@c1d73ec |
@yosifkit I've added @docker-library-bot back with write permissions. Can you add the job back? |
There are no new image tags on Docker hub since the 2.4.1 release. Any update on this issue? |
sorry @northway .. this is a two step process: update this repo and open a PR to official docker images.. but I missed the second part.. it is done now docker-library/official-images#7452 just need to wait for them to merge. we still need to automate this process though |
Doh sorry, I think this failed due to the same reason it got kicked off in the first place -- it's a bot, so 2FA is a bit complicated (so it can't actually accept the invite). |
@tianon any idea on how to handle this? |
Using @docker-library-bot, I'm not sure, but you should be able to accomplish something very similar using GitHub Actions or Travis -- it just runs |
In this case, I think making sure |
Can you trigger the release again? I would like to upgrade our instances to 3.X... |
Yeah, |
I'm already on the verge of making my own CD pipeline. |
@tianon @pierreozoux
I'm not sure who to ping here. Pretty much from the start this has been a community maintained repo. Because of that its been a bit hands off and just let things run.
We'd like to get a bit more hands on and assure this image gets the same sort of quality as the one in our own repo.
So we'd really like to understand how exactly the pieces here fit together and how we can improve. I don't know if here is the best way or if via email.
The text was updated successfully, but these errors were encountered: