Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Baseimage back to Node-Baseimage for better maintainability #104

Closed
wants to merge 5 commits into from

Conversation

snoopotic
Copy link

@snoopotic snoopotic commented Feb 9, 2020

Also bumping to new Version 3.0.2 and fixing an issue if you try to build the image on an host with ipV6 enabled.

…baseimage. also bumping to new Version 2.4.8 and fixing an issue if you try to build the image on an host with ipV6 enabled.
…ntain some libs. also adding imagemagick and fontconfig to work properly behind reverseproxies.
Signed-off-by: Felix Herzog <snoopotic@gmail.com>
@snoopotic snoopotic changed the title As rocketchat is now build on node >8.15 we can return back to 'node'… Change Baseimage back to Node-Baseimage for better maintainability Feb 23, 2020
…ted node 14.12 and Rocketchat 3.0.2 ;)

Signed-off-by: Felix Herzog <snoopotic@gmail.com>
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to take a look on this..

I tried building this one and got the following error:

Sending build context to Docker daemon  3.584kB
Step 1/14 : FROM node:14.12-slim
manifest for node:14.12-slim not found: manifest unknown: manifest unknown

not sure it was available at the time you opened the PR, but right now I got this.

Signed-off-by: Felix Herzog <snoopotic@gmail.com>
@snoopotic
Copy link
Author

Oh my. I am very sorry wasting your time. I somehow rotated the node version numbers in the base image tag. I see next step is to implement an automated build.test :)

It should work now.

@sampaiodiego
Copy link
Member

lol I didn't realised the version was just inverted :P

@sampaiodiego
Copy link
Member

I'm afraid switching to node:12.14-slim we'll end up having issues as we had before since this version is not on supported tags anymore (only 12.16 currently is https://github.com/docker-library/official-images/blob/master/library/node), please look on previous discussions at:

#57 (comment)
https://travis-ci.org/docker-library/official-images/builds/449066913

wdyt @geekgonecrazy ?

Maybe it is safe to keep using debian

@snoopotic
Copy link
Author

Well, node:12.14-slim is a debian based image.
Well, you could switch to 12.16-slim as newest 12 but I just followed the notes on the releasenotes (https://github.com/RocketChat/Rocket.Chat/releases) and they state node 12.14. I assume this is a tested node version... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants