-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Baseimage back to Node-Baseimage for better maintainability #104
Conversation
…baseimage. also bumping to new Version 2.4.8 and fixing an issue if you try to build the image on an host with ipV6 enabled.
…ntain some libs. also adding imagemagick and fontconfig to work properly behind reverseproxies.
Signed-off-by: Felix Herzog <snoopotic@gmail.com>
…ted node 14.12 and Rocketchat 3.0.2 ;) Signed-off-by: Felix Herzog <snoopotic@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long to take a look on this..
I tried building this one and got the following error:
Sending build context to Docker daemon 3.584kB
Step 1/14 : FROM node:14.12-slim
manifest for node:14.12-slim not found: manifest unknown: manifest unknown
not sure it was available at the time you opened the PR, but right now I got this.
Signed-off-by: Felix Herzog <snoopotic@gmail.com>
Oh my. I am very sorry wasting your time. I somehow rotated the node version numbers in the base image tag. I see next step is to implement an automated build.test :) It should work now. |
lol I didn't realised the version was just inverted :P |
I'm afraid switching to #57 (comment) wdyt @geekgonecrazy ? Maybe it is safe to keep using |
Well, node:12.14-slim is a debian based image. |
Also bumping to new Version 3.0.2 and fixing an issue if you try to build the image on an host with ipV6 enabled.