Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweaks and readme updates - closes #2 #3

Merged
merged 2 commits into from
Jul 13, 2015
Merged

tweaks and readme updates - closes #2 #3

merged 2 commits into from
Jul 13, 2015

Conversation

Sing-Li
Copy link
Member

@Sing-Li Sing-Li commented Jul 11, 2015

@pierreozoux
Tested, everything is working - thanks!

Suggested mods:

  1. change maintainer to buildmaster for HA, email alias can forward to a group
  2. added comments to explain the MONGO_URL embed
  3. modified README to suit both container linking and external ip-explicit Mongo sources

Otherwise, I think we are good to go.

pierreozoux added a commit that referenced this pull request Jul 13, 2015
@pierreozoux
Merge pull request #3 from RocketChat/readme-tweaks
3a0298d 
tweaks and readme updates - closes #2
@pierreozoux pierreozoux merged commit 3a0298d into master Jul 13, 2015
@pierreozoux
Copy link
Collaborator

Excellent!

@pierreozoux pierreozoux deleted the readme-tweaks branch July 13, 2015 08:04
@cadrogui cadrogui mentioned this pull request Mar 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sing-Li @pierreozoux