Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix of display text when user is typing #372

Open
umangutkarsh opened this issue Dec 31, 2023 · 1 comment · May be fixed by #381
Open

Fix of display text when user is typing #372

umangutkarsh opened this issue Dec 31, 2023 · 1 comment · May be fixed by #381
Labels
bug Something isn't working

Comments

@umangutkarsh
Copy link
Contributor

Description:

To fix the display of text, when a user is typing. It should be displayed only when others are typing.
Not to display when user1 is typing. It should only be displayed to user1 when user2 is typing.

Example-- Should be displayed <user2> is typing... to user1 and Vice-versa

Steps to reproduce:

  1. Go to Chat area.
  2. Type some message
  3. See your_name displayed as <your_name> is typing...

Expected behavior:

Should only be displayed when others are typing.

Actual behavior:

type3.webm
@umangutkarsh umangutkarsh added the bug Something isn't working label Dec 31, 2023
@umangutkarsh umangutkarsh changed the title UX fix of display text when user is typing Fix of display text when user is typing Dec 31, 2023
asrar211 added a commit to asrar211/EmbeddedChat that referenced this issue Jan 1, 2024
@asrar211
Fixed display text when user is typing RocketChat#372
58396aa
@umangutkarsh umangutkarsh linked a pull request Jan 2, 2024 that will close this issue
Open
2 tasks
@umangutkarsh
Copy link
Contributor Author

umangutkarsh commented Jan 2, 2024 •
edited
Loading

Hi @sidmohanty11 . I've opened PR(#381 ) to fix the issue mentioned by you in the comments of #367 . Please review it and let me know if anything is required.
Thanks

umangutkarsh added a commit to umangutkarsh/EmbeddedChat that referenced this issue Jan 18, 2024
@umangutkarsh
Merge branch 'develop' into fix/RocketChat#367-and-RocketChat#372-typ…
69fcb25 
…ing-text-fix
@umangutkarsh umangutkarsh mentioned this issue Feb 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typing-display-fix umangutkarsh/EmbeddedChat
1 participant
@umangutkarsh