Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified root folder's README file for better explanation #65

Closed
wants to merge 10 commits into from
Closed

modified root folder's README file for better explanation #65

wants to merge 10 commits into from

Conversation

Dev-Code24
Copy link
Contributor

README.MD file updated

gave a better explanation for a better understanding

Video/Screenshots

image

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dev-Code24 thanks a lot for your PR! Can we change it to something like -> # at the root folder - embeddedchat?

Also, I had some other Readme changes in mind, please feel free to add them and modify the README into a cool one if you are willing to.

  • Addition of a link to the Wiki/FAQs page for videos,
  • Link to Roots of EmbeddedChat wiki with a link to this that will help people get a better sense of understanding of its internals.
  • A cool screenshot maybe! You can refer this
  • Add headerColor, toastBarPosition to the props list and update its description, refer this

Feel free to add more to this list if you think something else needs to be changed. This will be a significant contribution!

@Dev-Code24
Copy link
Contributor Author

Hey @Dev-Code24 thanks a lot for your PR! Can we change it to something like -> # at the root folder - embeddedchat?

Also, I had some other Readme changes in mind, please feel free to add them and modify the README into a cool one if you are willing to.

  • Addition of a link to the Wiki/FAQs page for videos,
  • Link to Roots of EmbeddedChat wiki with a link to this that will help people get a better sense of understanding of its internals.
  • A cool screenshot maybe! You can refer this
  • Add headerColor, toastBarPosition to the props list and update its description, refer this

Feel free to add more to this list if you think something else needs to be changed. This will be a significant contribution!

yeah sure I will make these changes

@Dev-Code24
Copy link
Contributor Author

Dev-Code24 commented Dec 24, 2022

@sidmohanty11
I have made the changes as per request, but I was unable to put a cool screenshot and sorry for so many commits as they happened by mistake

Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dev-Code24 can you please revert to your first commit.

@sidmohanty11
Copy link
Collaborator

Hey @Dev-Code24 thanks a lot for your PR! Can we change it to something like -> # at the root folder - embeddedchat?

Also, I had some other Readme changes in mind, please feel free to add them and modify the README into a cool one if you are willing to.

  • Addition of a link to the Wiki/FAQs page for videos,
  • Link to Roots of EmbeddedChat wiki with a link to this that will help people get a better sense of understanding of its internals.
  • A cool screenshot maybe! You can refer this
  • Add headerColor, toastBarPosition to the props list and update its description, refer this

Feel free to add more to this list if you think something else needs to be changed. This will be a significant contribution!

@Dev-Code24 I am making this a separate issue to take up! Just make your initial changes with making the comment more descriptive -> by adding something like -> at the root folder - EmbeddedChat

@sidmohanty11 sidmohanty11 mentioned this pull request Dec 24, 2022
Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dev-Code24 rebase it please to the initial commit

@sidmohanty11
Copy link
Collaborator

@Dev-Code24
Copy link
Contributor Author

Git rebase: https://www.simplilearn.com/what-is-git-rebase-command-article

oh, so you meant this,
Thank you for sharing the link.

@Dev-Code24
Copy link
Contributor Author

Dev-Code24 commented Dec 24, 2022

@Dev-Code24 rebase it please to the initial commit

sorry for the trouble but can you please tell me what I need to do here, I can't understand how to rebase my final commit with the initial commit as in all the tuts I saw about the git rebase, they all are showing that "git rebase" is done with 2 branches: master/main and a feature branch. and I haven't made any feature branches

@sidmohanty11
Copy link
Collaborator

@Dev-Code24 you could try git reset it should be a bit easier I think

@Dev-Code24
Copy link
Contributor Author

Dev-Code24 commented Dec 25, 2022

@Dev-Code24 you could try git reset it should be a bit easier I think
I did git reset. Can you please help what should I do next? Like should I commit to something new or do a push, after doing git reset?

@sidmohanty11
Copy link
Collaborator

@Dev-Code24 you can do a force push

@Dev-Code24
Copy link
Contributor Author

@Dev-Code24 you can do a force push

The following is shown to me and I cannot see any changes

Screenshot 2022-12-25 at 20 01 16

@Dev-Code24 Dev-Code24 closed this Jan 10, 2023
@sidmohanty11
Copy link
Collaborator

Hey @Dev-Code24 , I'm so sorry for the late response. I am actually very busy with exams right now. Please feel free to open a new PR for this! Thanks !

@Dev-Code24
Copy link
Contributor Author

Hey @sidmohanty11 no problem, but I guess you said that you were going to do this, so shall I do it or you will do it?

@sidmohanty11
Copy link
Collaborator

Hey @Dev-Code24 thanks a lot for your PR! Can we change it to something like -> # at the root folder - embeddedchat?

Also, I had some other Readme changes in mind, please feel free to add them and modify the README into a cool one if you are willing to.

  • Addition of a link to the Wiki/FAQs page for videos,
  • Link to Roots of EmbeddedChat wiki with a link to this that will help people get a better sense of understanding of its internals.
  • A cool screenshot maybe! You can refer this
  • Add headerColor, toastBarPosition to the props list and update its description, refer this

Feel free to add more to this list if you think something else needs to be changed. This will be a significant contribution!

I deviated here actually, your PR was to specify the folder accurately but I introduced so many complications here. You can just make the initial PR with your changes (at root folder - EmbeddedChat)

@Dev-Code24
Copy link
Contributor Author

@sidmohanty11
Ok, I will do that.
One more thing I wanted to ask was can you actually help me by guiding me on how the mentors or the organizations select students/contributors for GSOC.
I am a 2nd-year student at DTU, Delhi, and wanted help from someone regarding GSOC.

@sidmohanty11
Copy link
Collaborator

@Dev-Code24 sure, you can ask your doubts in DM (RC or LinkedIN)

@Dev-Code24
Copy link
Contributor Author

Dev-Code24 commented Jan 10, 2023

@sidmohanty11

Yeah sure.
(https://www.linkedin.com/in/rajeev-lochan-14812922b)
This is my LinkedIn profile.
Can you share your LinkedIn profile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants