-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified root folder's README file for better explanation #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Dev-Code24 thanks a lot for your PR! Can we change it to something like -> # at the root folder - embeddedchat
?
Also, I had some other Readme changes in mind, please feel free to add them and modify the README into a cool one if you are willing to.
- Addition of a link to the Wiki/FAQs page for videos,
- Link to Roots of EmbeddedChat wiki with a link to this that will help people get a better sense of understanding of its internals.
- A cool screenshot maybe! You can refer this
- Add
headerColor
,toastBarPosition
to the props list and update its description, refer this
Feel free to add more to this list if you think something else needs to be changed. This will be a significant contribution!
yeah sure I will make these changes |
@sidmohanty11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dev-Code24 can you please revert to your first commit.
@Dev-Code24 I am making this a separate issue to take up! Just make your initial changes with making the comment more descriptive -> by adding something like -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dev-Code24 rebase it please to the initial commit
oh, so you meant this, |
sorry for the trouble but can you please tell me what I need to do here, I can't understand how to rebase my final commit with the initial commit as in all the tuts I saw about the git rebase, they all are showing that "git rebase" is done with 2 branches: master/main and a feature branch. and I haven't made any feature branches |
@Dev-Code24 you could try git reset it should be a bit easier I think |
|
@Dev-Code24 you can do a force push |
The following is shown to me and I cannot see any changes |
Hey @Dev-Code24 , I'm so sorry for the late response. I am actually very busy with exams right now. Please feel free to open a new PR for this! Thanks ! |
Hey @sidmohanty11 no problem, but I guess you said that you were going to do this, so shall I do it or you will do it? |
I deviated here actually, your PR was to specify the folder accurately but I introduced so many complications here. You can just make the initial PR with your changes (at root folder - EmbeddedChat) |
@sidmohanty11 |
@Dev-Code24 sure, you can ask your doubts in DM (RC or LinkedIN) |
Yeah sure. |
README.MD file updated
gave a better explanation for a better understanding
Video/Screenshots