Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added component to display Middleware HQ open source contributors' stats #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Amdadullah-Raihan
Copy link

Thank you for reviewing my pull request! I appreciate your time and feedback.

In this contribution, I added the component to display open-source contributors' stats. The goal was to provide a visual representation of the contributors' information in our own styling, using data fetched from the Middleware HQ API.

I designed the component to be modular and reusable, allowing for easy integration into different parts of our ecosystem. The styling and layout were carefully considered to ensure a user-friendly and visually appealing display.

I would love your input on the implementation details, code structure, and overall user experience. If you have any suggestions for improvement or any concerns, please let me know.

Once again, thank you for your time and support throughout this process!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Please take an in-depth look at how other components are implemented.

We cannot have runtime data fetch happening. Essentially this framework works by generating static artifacts that are scalably deployed to "dumb" edge servers.

This means that the data fetching must happen during build time. And the rendered artifacts be bundled and pushed out to the "dumb" edge servers at runtime. There is no data fetch that can happen during runtime. Thanks.

@Amdadullah-Raihan
Copy link
Author

Thanks for your feedback, sir. I will take an in-depth look at how other components are implemented and see if there are any ways to improve the performance of the data fetching. I will also ensure that all data fetching is done during build time and that no data fetch can happen during runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants