Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix leaderboard build fail #170

Merged
merged 5 commits into from
Jun 16, 2022
Merged

Conversation

Dnouv
Copy link
Member

@Dnouv Dnouv commented Jun 16, 2022

While running the npm run build the leaderboard component was giving an error and thus failing the build, it's been fixed now, in this PR.
Thank you!

@debdutdeb please have a review.

@Dnouv
Copy link
Member Author

Dnouv commented Jun 16, 2022

My bad, the issue is deeper than I thought. Please wait, I'll once again ping when the PR is ready.
Thanks!

@Dnouv Dnouv marked this pull request as draft June 16, 2022 08:46
@Dnouv Dnouv marked this pull request as ready for review June 16, 2022 10:18
@Dnouv
Copy link
Member Author

Dnouv commented Jun 16, 2022

This is done. Now the build is successful in my local development @debdutdeb @Sing-Li .

Thank you!

@Sing-Li
Copy link
Member

Sing-Li commented Jun 16, 2022

If it is fixing the CI / deploy, I wouldn't worry that much. We'll have a totally different CI / deploy loop on rc4conf.

@Sing-Li Sing-Li merged commit 13b5926 into RocketChat:master Jun 16, 2022
Dnouv added a commit to Dnouv/RC4Community that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants