Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] simple automated testing #54

Merged
merged 17 commits into from
Jan 29, 2022
Merged

[NEW] simple automated testing #54

merged 17 commits into from
Jan 29, 2022

Conversation

debdutdeb
Copy link
Member

I'll probably add additional steps for deploying to a staging env later.

@debdutdeb
ci: add automated build and run tests
a07e9c4 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
ci: mostly a rewrite
c8acfb9 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
README: add build status badge
aedce9b 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
README: convert badge from md to html <img>
ae917eb 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
README: put badge at the beginning of README
4b29c9d 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
ci: run on pr events iff marked as ready
80c6fb9 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
README: fix repo owner name (RocketChat !Rocket.Chat)
4fba96c 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Sing-Li
Sing-Li requested changes Jan 25, 2022
View reviewed changes
Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will / can we hook in:

  1. unit tests?
  2. end to end tests?

Please add a few mock test placeholders in the right place so we can extend this. Thanks.

@Sing-Li
Copy link
Member

Sing-Li commented Jan 25, 2022

Adding a "push to production" on releases (not every commit/PR) would be extremely helpful to close the CI/CD loop. Please talk with @RonLek on the production server community.rocket.chat deployment details.

@debdutdeb
Copy link
Member Author

@Sing-Li - about push to production, already on it. I have the server details on hand :)

@debdutdeb
ci: use strapi health api
7b01219 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
Copy link
Member Author

debdutdeb commented Jan 25, 2022 •
edited
Loading

About hooking tests in ci, depending on the testing framework and workflow, I'll add them once they're added to the project, no need to add placeholders atm :) Right now there are two simple tests to make sure the pr won't break deployment once merged.

@debdutdeb
remove package-lock from mr
9698cdc 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
restore package-lock
650a25a 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
ci: [wip] deploy to remote server if release published
2478f00 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb debdutdeb marked this pull request as draft January 26, 2022 11:37
@debdutdeb
ci: complete automatic deployment on release
308c4b9 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb debdutdeb marked this pull request as ready for review January 26, 2022 20:52
@debdutdeb debdutdeb marked this pull request as draft January 26, 2022 21:08
@debdutdeb debdutdeb marked this pull request as ready for review January 26, 2022 21:17
@debdutdeb debdutdeb marked this pull request as draft January 26, 2022 21:33
@debdutdeb
ci: update component start checks; remove cd
21d5e15 
* use js snippets to check health statuses
* remove deployment section

Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
ci: disable run on release published
39cac62 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
ci: check cmd statusCode
4d7e925 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb debdutdeb changed the title [NEW] automated building and simple testing [NEW] simple automated testing Jan 28, 2022
@debdutdeb
ci: disable building altogether
d5643e7 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb
README: change action status label
86fe198 
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@debdutdeb debdutdeb marked this pull request as ready for review January 28, 2022 23:56
@Sing-Li
Copy link
Member

Sing-Li commented Jan 29, 2022

OK. We're going to merge this. With the caveat that if the resource consumption proves to be too much or too expensive (for the simple ack that - yes, it builds) then we will disable it. Thanks @debdutdeb !

@Sing-Li Sing-Li merged commit 82cb853 into RocketChat:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sing-Li Sing-Li Sing-Li requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@debdutdeb @Sing-Li